线上出现「订单明细绑到了别家店铺的商品」:旧解析接口(`POST /api/order-items/{id}/parse`
与 `POST /api/orders/{id}/parse-items`)匹配店铺商品时只按 `principal_id + 平台商品ID +
规格ID` 查,同一个平台商品被多个店铺采集时(同款分销、多店铺同源)会命中别家店铺的行,
把别家的规格与绑定关系套到本单上,出库会发错货。
- 新增 lib/shopProductMatch.shopProductScope:匹配条件的唯一口径 —— 有店铺信息时只认本店铺,
只有无店铺信息的手工明细才退回主体范围;拉单(externalPrintOrder)与重解析共用它
- 解析逻辑下沉到 service/orderItemParse(`findShopProduct` / `isStaleShopProduct` /
`resolveItem` / `parseOrderItems`)。原来 order.js 里用的 `ctx.controller.orderItem`
在 Egg 里并不存在(controller 只挂到 app.controller),该接口一直是 500
- 失效关联自愈:明细指向别家店铺或已被删除的店铺商品时,重解析会连带清空
product_id/combo_product_id/item_type,不再沿用错误的系统商品;批量解析不再跳过这类脏数据
- 单测补 shopProductScope 4 例(本店铺 / 手工退回主体 / 空规格 / 缺商品ID)
实测(真实库,插入即回滚):shop 18 有、shop 19 没有时解析结果 shop_product_id=null、
product_id 同时被清空;补上 shop 19 的商品后命中 shop_product_id=1077、parse_status=1。
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
67 lines
2.9 KiB
JavaScript
67 lines
2.9 KiB
JavaScript
'use strict';
|
||
|
||
const { assert } = require('egg-mock/bootstrap');
|
||
const { createShopProductMatcher, shopProductScope } = require('../../../app/lib/shopProductMatch');
|
||
|
||
describe('app/lib/shopProductMatch 店铺商品匹配口径', () => {
|
||
const rows = [
|
||
{ id: 11, outer_item_id: '3773823319627923739', outer_sku_id: '3548726733104642' },
|
||
{ id: 12, outer_item_id: '3773823319627923739', outer_sku_id: '3548726733104898' },
|
||
{ id: 21, outer_item_id: '881526926136', outer_sku_id: '' },
|
||
{ id: 22, outer_item_id: '881526926136', outer_sku_id: '006-1' },
|
||
];
|
||
|
||
it('明细带规格ID时精确命中同规格', () => {
|
||
const pick = createShopProductMatcher(rows);
|
||
assert.strictEqual(pick({ outer_item_id: '3773823319627923739', outer_sku_id: '3548726733104898' }), 12);
|
||
assert.strictEqual(pick({ outer_item_id: '881526926136', outer_sku_id: '006-1' }), 22);
|
||
});
|
||
|
||
it('规格ID对不上时不退化成按商品ID随便取一条', () => {
|
||
const pick = createShopProductMatcher(rows);
|
||
assert.strictEqual(pick({ outer_item_id: '3773823319627923739', outer_sku_id: '999' }), null);
|
||
});
|
||
|
||
it('明细没有规格ID时按商品ID取 id 最小的那条', () => {
|
||
const pick = createShopProductMatcher(rows);
|
||
assert.strictEqual(pick({ outer_item_id: '3773823319627923739', outer_sku_id: '' }), 11);
|
||
assert.strictEqual(pick({ outer_item_id: '881526926136' }), 21);
|
||
});
|
||
|
||
it('空输入返回 null', () => {
|
||
const pick = createShopProductMatcher(rows);
|
||
assert.strictEqual(pick({ outer_item_id: '', outer_sku_id: '1' }), null);
|
||
assert.strictEqual(pick({ outer_item_id: '404' }), null);
|
||
assert.strictEqual(pick(null), null);
|
||
assert.strictEqual(createShopProductMatcher([])({ outer_item_id: '1' }), null);
|
||
});
|
||
|
||
describe('shopProductScope 查询口径', () => {
|
||
it('有店铺信息时只认本店铺,不带主体条件', () => {
|
||
assert.deepStrictEqual(
|
||
shopProductScope({ outer_item_id: '3773823319627923739', outer_sku_id: '3548726733104642' }, { shopId: 19, principalId: 5 }),
|
||
{ outer_item_id: '3773823319627923739', outer_sku_id: '3548726733104642', shop_id: 19 }
|
||
);
|
||
});
|
||
|
||
it('没有店铺信息(手工明细)才退回主体范围', () => {
|
||
assert.deepStrictEqual(
|
||
shopProductScope({ outer_item_id: '881526926136' }, { principalId: 5 }),
|
||
{ outer_item_id: '881526926136', principal_id: 5 }
|
||
);
|
||
});
|
||
|
||
it('明细没有规格ID时按商品ID匹配,空规格不写入条件', () => {
|
||
assert.deepStrictEqual(
|
||
shopProductScope({ outer_item_id: '881526926136', outer_sku_id: ' ' }, { shopId: '19' }),
|
||
{ outer_item_id: '881526926136', shop_id: 19 }
|
||
);
|
||
});
|
||
|
||
it('没有平台商品ID时返回 null(不能按空条件乱查)', () => {
|
||
assert.strictEqual(shopProductScope({ outer_sku_id: '1' }, { shopId: 19 }), null);
|
||
assert.strictEqual(shopProductScope(null, { shopId: 19 }), null);
|
||
});
|
||
});
|
||
});
|