- wms_account 新增 is_custom_password(TINYINT(1) NOT NULL DEFAULT 0),同步模型与迁移 20261025135000;开发库、生产库均已执行 - user.getAccountInfo 返回 is_custom_password,仍不返回 password_hash/salt/last_login_ip - 新增 user.updateUsername:仅改当前账号,服务端重名校验并排除自己,重名返回 409,更新后清理用户缓存 - 新增 user.changePassword:is_custom_password=0 时旧密码可不传,修改后置 1;再次修改必须校验旧密码;已排除操作日志避免明文密码落库 - 单测覆盖 getAccountInfo/updateUsername/changePassword,20 通过;同步 AI_METHOD_ROUTING Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
189 lines
5.4 KiB
JavaScript
189 lines
5.4 KiB
JavaScript
'use strict';
|
||
|
||
const assert = require('node:assert/strict');
|
||
const { Op } = require('sequelize');
|
||
const UserMethodService = require('../../../../app/service/systemMethods/user');
|
||
const UserSystemService = require('../../../../app/service/systems/auth/user');
|
||
|
||
function createSystemHarness(options = {}) {
|
||
const calls = {
|
||
findOne: [],
|
||
update: [],
|
||
cleared: [],
|
||
};
|
||
const findOneResults = [ ...(options.findOneResults || []) ];
|
||
const ctx = {
|
||
app: { config: {}, Sequelize: { Op } },
|
||
userId: options.userId,
|
||
user: options.user,
|
||
logger: { error() {} },
|
||
model: {
|
||
Account: {
|
||
async findOne(args) {
|
||
calls.findOne.push(args);
|
||
return findOneResults.shift();
|
||
},
|
||
async update(values, updateOptions) {
|
||
calls.update.push({ values, updateOptions });
|
||
if (options.updateError) {
|
||
throw options.updateError;
|
||
}
|
||
return [ 1 ];
|
||
},
|
||
},
|
||
},
|
||
};
|
||
|
||
const service = new UserSystemService(ctx);
|
||
service.clearUserCache = async userId => {
|
||
calls.cleared.push(userId);
|
||
return true;
|
||
};
|
||
|
||
return { service, calls, ctx };
|
||
}
|
||
|
||
function createMethodHarness(updateUsername) {
|
||
const calls = [];
|
||
const ctx = {
|
||
app: { config: {}, Sequelize: {} },
|
||
logger: { error() {} },
|
||
service: {
|
||
systems: {
|
||
auth: {
|
||
user: {
|
||
async updateUsername(data) {
|
||
calls.push(data);
|
||
return updateUsername(data);
|
||
},
|
||
},
|
||
},
|
||
},
|
||
},
|
||
};
|
||
|
||
return {
|
||
service: new UserMethodService(ctx),
|
||
calls,
|
||
};
|
||
}
|
||
|
||
describe('test/app/service/systemMethods/user.updateUsername.test.js', () => {
|
||
it('应修改用户名并清理用户缓存', async () => {
|
||
const { service, calls, ctx } = createSystemHarness({
|
||
userId: 7,
|
||
user: { username: 'old_name' },
|
||
findOneResults: [
|
||
{ id: 7, username: 'old_name' },
|
||
null,
|
||
],
|
||
});
|
||
|
||
const result = await service.updateUsername({ username: ' new_name ' });
|
||
|
||
assert.equal(result.success, true);
|
||
assert.equal(result.code, 200);
|
||
assert.deepEqual(result.data, { id: 7, username: 'new_name' });
|
||
assert.deepEqual(calls.update, [{
|
||
values: { username: 'new_name' },
|
||
updateOptions: { where: { id: 7 } },
|
||
}]);
|
||
assert.deepEqual(calls.cleared, [ 7 ]);
|
||
assert.equal(calls.findOne[1].where.username, 'new_name');
|
||
assert.equal(calls.findOne[1].where.id[Op.ne], 7);
|
||
assert.equal(ctx.user.username, 'new_name');
|
||
});
|
||
|
||
it('用户名未变化时直接返回成功且不更新', async () => {
|
||
const { service, calls } = createSystemHarness({
|
||
userId: 7,
|
||
findOneResults: [
|
||
{ id: 7, username: 'same_name' },
|
||
],
|
||
});
|
||
|
||
const result = await service.updateUsername({ username: 'same_name' });
|
||
|
||
assert.equal(result.success, true);
|
||
assert.equal(result.code, 200);
|
||
assert.equal(result.message, '用户名未变更');
|
||
assert.equal(calls.update.length, 0);
|
||
});
|
||
|
||
it('重名(排除自己)应返回 409', async () => {
|
||
const { service, calls } = createSystemHarness({
|
||
userId: 7,
|
||
findOneResults: [
|
||
{ id: 7, username: 'old_name' },
|
||
{ id: 9, username: 'taken_name' },
|
||
],
|
||
});
|
||
|
||
const result = await service.updateUsername({ username: 'taken_name' });
|
||
|
||
assert.equal(result.success, false);
|
||
assert.equal(result.code, 409);
|
||
assert.equal(result.message, '用户名已存在');
|
||
assert.equal(calls.update.length, 0);
|
||
});
|
||
|
||
it('唯一索引冲突应兜底返回 409', async () => {
|
||
const duplicateError = new Error('Duplicate entry');
|
||
duplicateError.parent = { code: 'ER_DUP_ENTRY' };
|
||
const { service } = createSystemHarness({
|
||
userId: 7,
|
||
findOneResults: [
|
||
{ id: 7, username: 'old_name' },
|
||
null,
|
||
],
|
||
updateError: duplicateError,
|
||
});
|
||
|
||
const result = await service.updateUsername({ username: 'new_name' });
|
||
|
||
assert.equal(result.success, false);
|
||
assert.equal(result.code, 409);
|
||
assert.equal(result.message, '用户名已存在');
|
||
});
|
||
|
||
it('用户名格式非法应返回 400', async () => {
|
||
const { service, calls } = createSystemHarness({ userId: 7 });
|
||
|
||
const shortResult = await service.updateUsername({ username: 'ab' });
|
||
const invalidResult = await service.updateUsername({ username: 'bad-name' });
|
||
|
||
assert.equal(shortResult.code, 400);
|
||
assert.equal(invalidResult.code, 400);
|
||
assert.equal(calls.findOne.length, 0);
|
||
});
|
||
|
||
it('未登录返回 401,账号不存在返回 404', async () => {
|
||
const anonymous = createSystemHarness({});
|
||
const missing = createSystemHarness({
|
||
userId: 7,
|
||
findOneResults: [ null ],
|
||
});
|
||
|
||
const anonymousResult = await anonymous.service.updateUsername({ username: 'new_name' });
|
||
const missingResult = await missing.service.updateUsername({ username: 'new_name' });
|
||
|
||
assert.equal(anonymousResult.code, 401);
|
||
assert.equal(missingResult.code, 404);
|
||
});
|
||
|
||
it('方法层应保留业务失败码', async () => {
|
||
const { service, calls } = createMethodHarness(async () => ({
|
||
success: false,
|
||
data: null,
|
||
code: 409,
|
||
message: '用户名已存在',
|
||
}));
|
||
|
||
const result = await service.updateUsername({ username: 'taken_name' });
|
||
|
||
assert.equal(result.flag, 'failure');
|
||
assert.equal(result.code, 409);
|
||
assert.deepEqual(calls, [{ username: 'taken_name' }]);
|
||
});
|
||
});
|